Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: add lock for forward tso stream (#9095) #9107

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9095

What problem does this PR solve?

Issue Number: Close #9091

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
go test -benchmem -run=^$ -bench ^BenchmarkForwardTsoConcurrently$ github.com/tikv/pd/tests/integrations/mcs/tso -benchtime 120s

client = 3
164         776899433 ns/op        52592338 B/op     446288 allocs/op
182         779831256 ns/op        52671058 B/op     446771 allocs/op
176         776116538 ns/op        52677991 B/op     446741 allocs/op

client = 1
386         342842281 ns/op        17493004 B/op     146447 allocs/op
390         344128967 ns/op        17487349 B/op     146318 allocs/op
379         356701493 ns/op        17528155 B/op     146427 allocs/op

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 27, 2025
@ti-chi-bot
Copy link
Member Author

@lhy1024 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2025
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2025
@lhy1024 lhy1024 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 3, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [bufferflies,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-03 07:07:51.10684569 +0000 UTC m=+252584.235765429: ☑️ agreed by bufferflies.
  • 2025-03-03 07:15:36.922247654 +0000 UTC m=+253050.051167394: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 4a40114 into tikv:release-7.1 Mar 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants